Updated package-json dependency
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't update yarn.lock as I'm not sure your procedure for that, and I'm using the web-editor currently.
🦋 Changeset detectedLatest commit: a4e6fbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It went ESM-only
|
I need your assistance for what kind of changeset to include, as this affects many dependencies (in yarn.lock), but doesn't affect Manypkg's API. |
|
Looks like my PR expands on #176 -- sorry I didn't notice it! |
Shravankumarkarnati
approved these changes
Jul 17, 2023
eknowles
approved these changes
Sep 5, 2023
|
Is the project still maintained? If so can we merge this, Snyk marked this vulnerability as critical. |
Andarist
changed the title
package-json dependency
Andarist
approved these changes
Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #180
package-json went ESM-only, but we only use it in one place in upgrade.ts, and the error that was thrown told me to use a dynamic import, so I did. It was already an
asynccontext, so I think this is fine?The tests pass!
Many yarn.lock updates though!